Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more tests on AArch64 #2994

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

akirilov-arm
Copy link
Contributor

These changes are partially in support of #2960. With them the tests run on AArch64 should be the same as those executing on x86-64, except for a couple that are specific to the latter platform, 3 that fail under QEMU, and some CLIF tests missing the target aarch64 directive.

@github-actions github-actions bot added the wasmtime:api Related to the API of the `wasmtime` crate itself label Jun 17, 2021
@github-actions
Copy link

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

build.rs Outdated Show resolved Hide resolved
tests/all/func.rs Outdated Show resolved Hide resolved
@akirilov-arm
Copy link
Contributor Author

Well, on the plus side all AArch64 tests pass (including the new additions), but now there is a macOS failure, even though my patch is not supposed to change anything for that platform (since it is not AArch64-based in CI).

@alexcrichton Any suggestions?

@alexcrichton
Copy link
Member

Oh that's ok, that's a known flaky test failure

@alexcrichton
Copy link
Member

(cc @pchickey on the flaky test failure)

---- wasi_tokio::poll_oneoff_files stdout ----
preopen: "/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/wasi_common_poll_oneoff_filesIp62sX"
guest stderr:
thread 'main' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `2`: should return 2 events, got: [Event { userdata: 1, error: 0, type: 1, fd_readwrite: EventFdReadwrite { nbytes: 1, flags: 0 } }]', src/bin/poll_oneoff_files.rs:128:5
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

===
Error: error while testing Wasm module 'poll_oneoff_files'

Caused by:
    wasm trap: unreachable
    wasm backtrace:
        0: 0xa30f - <unknown>!__rust_start_panic
        1: 0xa078 - <unknown>!rust_panic
        2: 0x9c0e - <unknown>!std::panicking::rust_panic_with_hook::h7d1c07b3a075203c
        3: 0x926e - <unknown>!std::panicking::begin_panic_handler::{{closure}}::h3513767ae6c4d95c
        4: 0x91af - <unknown>!std::sys_common::backtrace::__rust_end_short_backtrace::h0bbf8ae75ca302c2
        5: 0x9ab2 - <unknown>!rust_begin_unwind
        6: 0xf595 - <unknown>!core::panicking::panic_fmt::h2e0bed4f7ae7c673
        7: 0x100e2 - <unknown>!core::panicking::assert_failed::inner::h46820b6921ccb429
        8: 0x2838 - <unknown>!core::panicking::assert_failed::h2221a87facc4d20e
        9: 0x192c - <unknown>!poll_oneoff_files::main::hab2a34e94500766e
       10: 0x251b - <unknown>!std::sys_common::backtrace::__rust_begin_short_backtrace::h5bcb8183023cbb77
       11: 0x2552 - <unknown>!std::rt::lang_start::{{closure}}::hd9d6d2df6808b2fc
       12: 0xa123 - <unknown>!std::rt::lang_start_internal::h1e63ab493c96e529
       13: 0x2296 - <unknown>!__original_main
       14:  0x575 - <unknown>!_start
       15: 0x13326 - <unknown>!_start.command_export
    note: run with `WASMTIME_BACKTRACE_DETAILS=1` environment variable to display more information
    
thread 'wasi_tokio::poll_oneoff_files' panicked at 'assertion failed: `(left == right)`
  left: `1`,
 right: `0`: the test returned a termination value with a non-zero status code (1) which indicates a failure', /rustc/53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b/library/test/src/lib.rs:193:5
stack backtrace:
   0: rust_begin_unwind
             at /rustc/53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b/library/std/src/panicking.rs:493:5
   1: core::panicking::panic_fmt
             at /rustc/53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b/library/core/src/panicking.rs:92:14
   2: core::panicking::assert_failed::inner
             at /rustc/53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b/library/core/src/panicking.rs:129:27
   3: core::panicking::assert_failed
             at /rustc/53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b/library/core/src/panicking.rs:143:5
   4: test::assert_test_result
             at /rustc/53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b/library/test/src/lib.rs:193:5
   5: wasm_tests::wasi_tokio::poll_oneoff_files::{{closure}}
             at /Users/runner/work/wasmtime/wasmtime/target/debug/build/test-programs-5789f8ca0671ec50/out/wasi_tests.rs:714:5
   6: core::ops::function::FnOnce::call_once
             at /rustc/53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b/library/core/src/ops/function.rs:227:5
   7: core::ops::function::FnOnce::call_once
             at /rustc/53cb7b09b00cbea8754ffb78e7e3cb521cb8af4b/library/core/src/ops/function.rs:227:5
note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.


failures:
    wasi_tokio::poll_oneoff_files

@akirilov-arm
Copy link
Contributor Author

Oh that's ok, that's a known flaky test failure

OK, I started another run - hopefully it will pass this time.

build.rs Outdated Show resolved Hide resolved
@uweigand
Copy link
Member

This looks good to me now, as far as s390x is concerned. Thanks!

build.rs Outdated Show resolved Hide resolved
tests/all/gc.rs Outdated Show resolved Hide resolved
Copyright (c) 2021, Arm Limited.
@alexcrichton alexcrichton merged commit cb93726 into bytecodealliance:main Jun 21, 2021
@alexcrichton
Copy link
Member

👍

@akirilov-arm akirilov-arm deleted the aarch64_tests branch June 21, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants