-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable more tests on AArch64 #2994
Enable more tests on AArch64 #2994
Conversation
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "wasmtime:api"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
19e218b
to
7c197fa
Compare
Well, on the plus side all AArch64 tests pass (including the new additions), but now there is a macOS failure, even though my patch is not supposed to change anything for that platform (since it is not AArch64-based in CI). @alexcrichton Any suggestions? |
Oh that's ok, that's a known flaky test failure |
(cc @pchickey on the flaky test failure)
|
OK, I started another run - hopefully it will pass this time. |
7c197fa
to
d0e31ce
Compare
This looks good to me now, as far as s390x is concerned. Thanks! |
Copyright (c) 2021, Arm Limited.
d0e31ce
to
5f482e2
Compare
👍 |
These changes are partially in support of #2960. With them the tests run on AArch64 should be the same as those executing on x86-64, except for a couple that are specific to the latter platform, 3 that fail under QEMU, and some CLIF tests missing the
target aarch64
directive.