Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running enter/exit hooks on start functions #3001

Merged
merged 1 commit into from
Jun 21, 2021

Commits on Jun 18, 2021

  1. Fix running enter/exit hooks on start functions

    This commit fixes running the store's enter/exit hooks into wasm which
    accidentally weren't run for an instance's `start` function. The fix
    here was mostly to just sink the enter/exit hook much lower in the code
    to `invoke_wasm_and_catch_traps`, which is the common entry point for
    all wasm calls.
    
    This did involve propagating the `StoreContext<T>` generic rather than
    using `StoreOpaque` unfortunately, but it is overally not too too much
    code and we generally wanted most of it inlined anyway.
    alexcrichton committed Jun 18, 2021
    Configuration menu
    Copy the full SHA
    f3ddf2e View commit details
    Browse the repository at this point in the history