Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Saturating Rounding Q-format Multiplication for x64 #3105

Merged

Conversation

jlb6740
Copy link
Contributor

@jlb6740 jlb6740 commented Jul 21, 2021

No description provided.

@jlb6740 jlb6740 force-pushed the implement-sat-int-q-round-mul branch from 29ae1d6 to 9dccfe1 Compare July 21, 2021 18:30
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:x64 Issues related to x64 codegen labels Jul 21, 2021
@jlb6740 jlb6740 force-pushed the implement-sat-int-q-round-mul branch from 9dccfe1 to 28642b3 Compare July 26, 2021 21:01
@jlb6740 jlb6740 requested review from abrown and cfallin July 26, 2021 21:02
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from the accidental (?) removal of movdqa below and some comment nits. Thanks!

cranelift/codegen/src/isa/x64/inst/emit.rs Show resolved Hide resolved
cranelift/codegen/src/isa/x64/lower.rs Outdated Show resolved Hide resolved
cranelift/codegen/src/isa/x64/lower.rs Outdated Show resolved Hide resolved
@jlb6740 jlb6740 force-pushed the implement-sat-int-q-round-mul branch from 28642b3 to 14a25fb Compare July 27, 2021 02:58
@jlb6740 jlb6740 merged commit 5deda27 into bytecodealliance:main Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants