Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cranelift: Port vselect over to ISLE on x64 #3659

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Jan 6, 2022

No description provided.

@fitzgen fitzgen requested a review from alexcrichton January 6, 2022 22:11
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:x64 Issues related to x64 codegen isle Related to the ISLE domain-specific language labels Jan 6, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2022

Subscribe to Label Action

cc @cfallin, @fitzgen

This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"

Thus the following users have been cc'd because of the following labels:

  • cfallin: isle
  • fitzgen: isle

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@abrown
Copy link
Contributor

abrown commented Jan 6, 2022

@fitzgen, just a heads up that I have a "port select to ISLE" change in-progress; just letting you know since I've seen some select-related changes recently. Do you want to take over select?

@fitzgen fitzgen merged commit 6b5e9d8 into bytecodealliance:main Jan 6, 2022
@fitzgen fitzgen deleted the vselect-isle branch January 6, 2022 22:51
@fitzgen
Copy link
Member Author

fitzgen commented Jan 6, 2022

Do you want to take over select?

I don't need to at the moment, I have my hands full with sshr now.

v1 = iabs v0
return v1
}
; run: %iabs_i32x4([0 2147483647 -2147483647 -2147483648]) == [0 2147483647 2147483647 -2147483648]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you remove these tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:x64 Issues related to x64 codegen cranelift Issues related to the Cranelift code generator isle Related to the ISLE domain-specific language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants