cranelift: port sshr to ISLE on x64
#3681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cranelift
fitzgen
force-pushed
the
port-sshr-to-isle
branch
from
375e336
to
f16ac6c
Compare
Subscribe to Label Action
This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "cranelift:area:machinst", "cranelift:area:x64", "isle"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
fitzgen
force-pushed
the
port-sshr-to-isle
branch
from
f16ac6c
to
0514b8c
Compare
|
Okay I fixed the masking of |
fitzgen
force-pushed
the
port-sshr-to-isle
branch
from
0514b8c
to
97c776c
Compare
alexcrichton
approved these changes
Jan 11, 2022
cranelift/filetests/filetests/isa/x64/simd-bitwise-compile.clif
Outdated
Show resolved
Hide resolved
fitzgen
force-pushed
the
port-sshr-to-isle
branch
from
97c776c
to
39e332c
Compare
fitzgen
force-pushed
the
port-sshr-to-isle
branch
from
39e332c
to
eff5b2d
Compare
fitzgen
commented
Jan 11, 2022
| ; Inst 9: movdqa %xmm1, %xmm0 | ||
| ; Inst 10: movq %rbp, %rsp | ||
| ; Inst 11: popq %rbp | ||
| ; Inst 12: ret |
There was a problem hiding this comment.
Managed to get it down to 12 instructions, instead of 13. Still one additional move compared to before. meh.
alexcrichton
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.