Minor instantiation benchmark updates #3790
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit has a few minor updates and some improvements to the
instantiation benchmark harness:
A
once_cell::unsync::Lazy
type is now used to guard creation ofmodules/engines/etc. This enables running singular benchmarks to be
much faster since the benchmark no longer compiles all other
benchmarks that are filtered out. Unfortunately I couldn't find a way
in criterion to test whether a
BenchmarkId
is filtered out or not sowe rely on the runtime laziness to initialize on the first run for
benchmarks that do so.
All files located in
benches/instantiation
are now loaded forbenchmarking instead of a hardcoded list. This makes it a bit easier
to throw files into the directory and have them benchmarked instead of
having to recompile when working with new files.
Finally a module deserialization benchmark was added to measure the
time it takes to deserialize a precompiled module from disk (inspired
by discussion on Use mmap'd
*.cwasm
as a source for memory initialization images #3787)While I was at it I also upped some limits to be able to instantiate
cfallin's
spidermonkey.wasm
.