Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aarch64: Implement bmask/bextend in ISLE #4358

Merged
merged 3 commits into from
Jul 1, 2022

Conversation

afonso360
Copy link
Contributor

👋 This PR Moves bmask and bextend to ISLE for aarch64.

Additionally as in #4331 we also remove the vector versions of bextend from the documentation.

It would also be a good idea to consider if we want to do the same to bmask since we did a similar thing to bint in #4299 and it looks like that the only implementation of vector bmask is on the interpreter.

cc: @abrown @cfallin @akirilov-arm

@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:meta Everything related to the meta-language. labels Jun 30, 2022
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few little requests for some details in comments.

cranelift/codegen/src/isa/aarch64/lower.isle Outdated Show resolved Hide resolved
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cfallin cfallin merged commit 38ecd37 into bytecodealliance:main Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:meta Everything related to the meta-language. cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants