Migrate most of wasmtime from lazy_static to once_cell #4368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
force-pushed
the
sunfishcode/minimize-lazy-static
branch
2 times, most recently
from
0e9b82a to
f32304e
Compare
bjorn3
reviewed
Jul 2, 2022
bjorn3
approved these changes
Jul 2, 2022
github-actions
bot
added
cranelift
Subscribe to Label Actioncc @cfallin, @fitzgen, @kubkon, @peterhuene
This issue or pull request has been labeled: "cranelift", "fuzzing", "isle", "wasi", "wasmtime:api"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
alexcrichton
approved these changes
Jul 5, 2022
sunfishcode
force-pushed
the
sunfishcode/minimize-lazy-static
branch
from
7af80ce to
b653340
Compare
sunfishcode
force-pushed
the
sunfishcode/minimize-lazy-static
branch
from
b653340 to
19cbc8f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several of Wasmtime's dependencies have migrated from lazy_static to once_cell, including crossbeam, clap, and tracing. This PR updates to those versions, and ports all of Wasmtime's own uses of lazy_static to once_cell.
And, once_cell has a friendlier API, with no macro and no
refkeyword.That said, there still are a few transitive dependencies on lazy_static.