Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cranelift: Add Rotates to fuzzer #4696

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

afonso360
Copy link
Contributor

@afonso360 afonso360 commented Aug 11, 2022

👋 Hey,

Now that #4519 is merged, we can add rotates to the fuzzer!

cc: @jameysharp

Copy link
Contributor

@jameysharp jameysharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But not shifts yet, huh? Well, that's okay, this is clearly an improvement.

FYI, I won't be reviewing more until Monday, so don't push more to this branch after I've turned on auto-merge or it probably won't go in until I'm back. 😅

@jameysharp jameysharp enabled auto-merge (squash) August 11, 2022 22:51
@afonso360
Copy link
Contributor Author

afonso360 commented Aug 11, 2022

I'm working on shifts now! We still don't fully support I128 shifts, but I was thinking of filing a issue and commiting it with the i128 cases commented out.

I'll do that as a separate PR though.

@jameysharp jameysharp merged commit 2be15ab into bytecodealliance:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants