Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable back-edge CFI by default on macOS #4720

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

akirilov-arm
Copy link
Contributor

This PR is a follow-up to #3606. One fiber test is still using the system unwinder implementation, so I have disabled it conservatively.

@alexcrichton
Copy link
Member

Wasmtime bits look good to me! 👍

@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:aarch64 Issues related to AArch64 backend. fuzzing Issues related to our fuzzing infrastructure labels Aug 16, 2022
@github-actions
Copy link

Subscribe to Label Action

cc @fitzgen

This issue or pull request has been labeled: "cranelift", "cranelift:area:aarch64", "fuzzing"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: fuzzing

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This generally looks good to me, and I manually verified it passes tests on macOS/aarch64. Just some regalloc-related comments below.

cranelift/codegen/src/isa/aarch64/inst/mod.rs Outdated Show resolved Hide resolved
cranelift/codegen/src/isa/aarch64/inst/mod.rs Outdated Show resolved Hide resolved
Also, adjust the tests that are executed on that platform. Finally,
fix a bug with obtaining backtraces when back-edge CFI is enabled.

Copyright (c) 2022, Arm Limited.
@bnjbvr
Copy link
Member

bnjbvr commented Aug 18, 2022

Thanks for taking a look! If it works by default on mac aarch64, I'm all in favor 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:aarch64 Issues related to AArch64 backend. cranelift Issues related to the Cranelift code generator fuzzing Issues related to our fuzzing infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants