x64: Lower fcopysign, ceil, floor, nearest, and trunc in ISLE #4730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cranelift
Subscribe to Label Action
This issue or pull request has been labeled: "cranelift", "cranelift:area:x64", "isle"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
cfallin
reviewed
Aug 18, 2022
| (rule (lower (has_type (use_sse41) (ceil a @ (value_type $F32)))) | ||
| (x64_roundss a (RoundImm.RoundUp))) | ||
|
|
||
| (rule (lower (ceil a @ (value_type $F32))) |
There was a problem hiding this comment.
Here we're implicitly relying on the rule-ordering heuristic again (that pesky #4717!): this rule doesn't do anything to guard on not SSE4.1 and it's not clear to me that the sequence of PatternInsts is "less specific" and shadowed by the above rule without going through the compilation in my head... let's leave this for now though as we are likely to resolve #4717 soon.
elliottt
force-pushed
the
trevor/x64-copysign-ceil-floor-nearest-trunc
branch
from
ff513b4 to
9a49520
Compare
elliottt
force-pushed
the
trevor/x64-copysign-ceil-floor-nearest-trunc
branch
from
9a49520 to
ef97072
Compare
cfallin
approved these changes
Aug 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for
fcopysign,ceil,floor,nearest, andtrunc, and lower all of those instructions in ISLE.