Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port vconst to ISLE (AArch64) #4750

Merged
merged 2 commits into from
Aug 23, 2022
Merged

Conversation

dheaton-arm
Copy link
Contributor

Ported the existing implementation of vconst to ISLE for AArch64, and
added support for 64-bit vector constants.

Also introduced 64-bit vconst support to the interpreter.

Copyright (c) 2022 Arm Limited

Ported the existing implementation of `vconst` to ISLE for AArch64, and
added support for 64-bit vector constants.

Also introduced 64-bit `vconst` support to the interpreter.

Copyright (c) 2022 Arm Limited
@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift:area:aarch64 Issues related to AArch64 backend. labels Aug 22, 2022
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A series of cleanup nits (or really one nit, repeated) below but otherwise LGTM.

cranelift/codegen/src/machinst/lower.rs Outdated Show resolved Hide resolved
cranelift/codegen/src/machinst/lower.rs Outdated Show resolved Hide resolved
cranelift/interpreter/src/step.rs Outdated Show resolved Hide resolved
Copyright (c) 2022 Arm Limited
@cfallin cfallin merged commit da1fb30 into bytecodealliance:main Aug 23, 2022
@dheaton-arm dheaton-arm deleted the isle-vconst branch August 24, 2022 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants