Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AArch64: port load and store operations to ISLE. #4785

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

cfallin
Copy link
Member

@cfallin cfallin commented Aug 25, 2022

This retains lower_amode in the handwritten code (@akirilov-arm
reports that there is an upcoming patch to port this), but tweaks it
slightly to take a Value rather than an Inst.

@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift:area:aarch64 Issues related to AArch64 backend. labels Aug 25, 2022
@cfallin cfallin changed the title AArch64: port load operations to ISLE. AArch64: port load and store operations to ISLE. Aug 25, 2022
@cfallin
Copy link
Member Author

cfallin commented Aug 29, 2022

Rebased over other ISLE-porting PR; ready for re-review now!

@cfallin cfallin requested a review from elliottt August 29, 2022 20:01
This retains `lower_amode` in the handwritten code (@akirilov-arm
reports that there is an upcoming patch to port this), but tweaks it
slightly to take a `Value` rather than an `Inst`.
Copy link
Member

@elliottt elliottt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@cfallin cfallin merged commit 955d4e4 into bytecodealliance:main Aug 30, 2022
@cfallin cfallin deleted the aarch64-isle-loads branch August 30, 2022 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants