cranelift: Test calling across different calling conventions #4801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
cranelift
jameysharp
approved these changes
Aug 29, 2022
There was a problem hiding this comment.
Seems straightforward to me. @cfallin, do you have any concerns about calls between different calling conventions?
I imagine this new test would trivially pass if we accidentally ignore the calling convention specifier. Anyone have any thoughts on how we could detect that particular kind of bug?
cfallin
approved these changes
Aug 29, 2022
|
|
||
| ; Tests calling across different calling conventions | ||
|
|
||
| function %callee_fast_i64(i64) -> i64 fast { |
There was a problem hiding this comment.
fast and system_v are actually the same in practice right now -- perhaps we could try system_v and windows_fastcall ?
There was a problem hiding this comment.
That might not work on aarch64 and s390x, but we can try one of the wasmtime ones.
|
This test still passes after merging with main. It's been a few days since CI ran so I thought I'd double-check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hey,
This is a continuation of the TODO items in #4667 . It looks like #4667 accidentally already enables us to mix calling conventions so we don't need to do anything except remove an unused error.
This is an important feature for #4566 since we decided to mark big/little endian behaviour via calling convention, so this allows us to write runtests for that.