cranelift: Register all functions in test file for interpreter #4817
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 Hey,
Lets try this again! The issue in #4800 was due to the signature checking that we included in #4782 being overly strict.
In the interpreter our
DataValue
s do not have full type information about their data. We only have a single boolean representationB
instead of one for each sizeb1/b8/b16/etc..
, this caused a error in the newcall.clif
tests since when we query the types of theseDataValue
s we just return a "Default" type. Which in this case wasb8
and different fromb1
in the signature, therefore a signature error!The solution in the last commit is to relax our signature checking constraints for these two type categories (bools & vectors).
cc: #4800
cc: #4810