Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cap-std 0.26. #4940

Merged

Conversation

sunfishcode
Copy link
Member

This is primarily to pull in bytecodealliance/cap-std#271, the fix for #4936, compilation on Rust nightly on Windows.

It also updates to rustix 0.35.10, to pull in bytecodealliance/rustix#403, the fix for bytecodealliance/rustix#402, compilation on newer versions of the libc crate, which changed a public function from unsafe to safe.

Fixes #4936.

This is primarily to pull in bytecodealliance/cap-std#271, the fix for bytecodealliance#4936,
compilation on Rust nightly on Windows.

It also updates to rustix 0.35.10, to pull in bytecodealliance/rustix#403,
the fix for bytecodealliance/rustix#402, compilation on newer versions of
the libc crate, which changed a public function from `unsafe` to safe.

Fixes bytecodealliance#4936.
@github-actions github-actions bot added wasi Issues pertaining to WASI wasmtime:c-api Issues pertaining to the C API. labels Sep 21, 2022
@github-actions
Copy link

Subscribe to Label Action

cc @kubkon, @peterhuene

This issue or pull request has been labeled: "wasi", "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

  • kubkon: wasi
  • peterhuene: wasmtime:c-api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@alexcrichton alexcrichton merged commit 6f50dda into bytecodealliance:main Sep 21, 2022
@sunfishcode sunfishcode deleted the sunfishcode/cap-std-0.26 branch September 21, 2022 20:09
@philpax
Copy link

philpax commented Sep 21, 2022

Thank you! Much appreciated 😊

@philpax
Copy link

philpax commented Sep 22, 2022

Are there any plans to cut a new 1.x release featuring this?

@pchickey
Copy link
Contributor

We release Wasmtime on a fixed cadence: https://github.com/bytecodealliance/rfcs/blob/main/accepted/wasmtime-one-dot-oh.md#release-process-and-cadence . So, this change will be out in a few weeks as part of 2.0

rvolosatovs added a commit to rvolosatovs/enarx that referenced this pull request Sep 23, 2022
This is required to be able to update nightly toolchain without breaking
Windows builds.

bytecodealliance/wasmtime#4940 is the patch
required, but it will only land in 2.0.0 according to bytecodealliance/wasmtime#4940 (comment)

Pin Wasmtime to a git rev until 2.0.0 release

Signed-off-by: Roman Volosatovs <roman@profian.com>
rvolosatovs added a commit to rvolosatovs/enarx that referenced this pull request Sep 23, 2022
This is required to be able to update nightly toolchain without breaking
Windows builds.

bytecodealliance/wasmtime#4940 is the patch
required, but it will only land in 2.0.0 according to bytecodealliance/wasmtime#4940 (comment)

Pin Wasmtime to a git rev until 2.0.0 release

Signed-off-by: Roman Volosatovs <roman@profian.com>
rvolosatovs added a commit to rvolosatovs/enarx that referenced this pull request Sep 23, 2022
This is required to be able to update nightly toolchain without breaking
Windows builds.

bytecodealliance/wasmtime#4940 is the patch
required, but it will only land in 2.0.0 according to bytecodealliance/wasmtime#4940 (comment)

Pin Wasmtime to a git rev until 2.0.0 release

Signed-off-by: Roman Volosatovs <roman@profian.com>
rvolosatovs added a commit to rvolosatovs/enarx that referenced this pull request Sep 23, 2022
This is required to be able to update nightly toolchain without breaking
Windows builds.

bytecodealliance/wasmtime#4940 is the patch
required, but it will only land in 2.0.0 according to bytecodealliance/wasmtime#4940 (comment)

Pin Wasmtime to a git rev until 2.0.0 release

Signed-off-by: Roman Volosatovs <roman@profian.com>
rvolosatovs added a commit to rvolosatovs/enarx that referenced this pull request Sep 23, 2022
This is required to be able to update nightly toolchain without breaking
Windows builds.

bytecodealliance/wasmtime#4940 is the patch
required, but it will only land in 2.0.0 according to bytecodealliance/wasmtime#4940 (comment)

Pin Wasmtime to a git rev until 2.0.0 release

Signed-off-by: Roman Volosatovs <roman@profian.com>
rvolosatovs added a commit to enarx/enarx that referenced this pull request Sep 23, 2022
This is required to be able to update nightly toolchain without breaking
Windows builds.

bytecodealliance/wasmtime#4940 is the patch
required, but it will only land in 2.0.0 according to bytecodealliance/wasmtime#4940 (comment)

Pin Wasmtime to a git rev until 2.0.0 release

Signed-off-by: Roman Volosatovs <roman@profian.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasi Issues pertaining to WASI wasmtime:c-api Issues pertaining to the C API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wasmtime 1.0.0's wasi-cap-std-sync doesn't compile with nightly Rust on Windows
4 participants