Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port branches to ISLE (AArch64) #4943

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

dheaton-arm
Copy link
Contributor

Ported the existing implementations of the following opcodes for AArch64 to ISLE:

  • Brz
  • Brnz
  • Brif
  • Brff
  • BrIcmp
  • Jump
  • BrTable

Copyright (c) 2022 Arm Limited

@github-actions github-actions bot added cranelift Issues related to the Cranelift code generator cranelift:area:aarch64 Issues related to AArch64 backend. labels Sep 22, 2022
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cfallin
Copy link
Member

cfallin commented Sep 22, 2022

Looks like a merge conflict with the other just-merged ISLE porting PR; happy to merge this once it's resolved.

Ported the existing implementations of the following opcodes for AArch64
to ISLE:
- `Brz`
- `Brnz`
- `Brif`
- `Brff`
- `BrIcmp`
- `Jump`
- `BrTable`

Copyright (c) 2022 Arm Limited
Copyright (c) 2022 Arm Limited
@github-actions github-actions bot added the cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. label Sep 23, 2022
@sparker-arm sparker-arm merged commit 3a2b32b into bytecodealliance:main Sep 26, 2022
@dheaton-arm dheaton-arm deleted the isle-branch branch September 26, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift:area:aarch64 Issues related to AArch64 backend. cranelift:area:machinst Issues related to instruction selection and the new MachInst backend. cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants