Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cranelift: constant propagate shifts #5671

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Cranelift: constant propagate shifts #5671

merged 1 commit into from
Jan 31, 2023

Conversation

fitzgen
Copy link
Member

@fitzgen fitzgen commented Jan 31, 2023

Thanks to Souper for pointing out we weren't doing this! cc @regehr

@fitzgen
Cranelift: constant propagate shifts
f7dce30 
Thanks to Souper for pointing out we weren't doing this!
@github-actions github-actions bot added the cranelift Issues related to the Cranelift code generator label Jan 31, 2023
cfallin
cfallin approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@fitzgen fitzgen added cranelift:goal:optimize-speed Focus area: the speed of the code produced by Cranelift. souper Issues and PRs related to the Souper superoptimizer labels Jan 31, 2023
jameysharp
jameysharp approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@jameysharp jameysharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right to me!

@fitzgen fitzgen merged commit 7aa240e into bytecodealliance:main Jan 31, 2023
@fitzgen fitzgen deleted the cprop-shifts branch January 31, 2023 20:06
@fitzgen fitzgen mentioned this pull request Mar 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cfallin cfallin cfallin approved these changes

@jameysharp jameysharp jameysharp approved these changes

Assignees
No one assigned
Labels
cranelift:goal:optimize-speed Focus area: the speed of the code produced by Cranelift. cranelift Issues related to the Cranelift code generator souper Issues and PRs related to the Souper superoptimizer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fitzgen @cfallin @jameysharp