Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the name of wit-bindgen's host implementation traits. #5890

Merged

Conversation

sunfishcode
Copy link
Member

Instead of naming the host implementation trait something like wasi_filesystem::WasiFilesystem, name it wasi_filesystem::Host, and avoid using the identifier Host in other places.

This fixes a collision when generating bindings for the current wasi-clock API, which contains an interface wall-clock which contains a type wall-clock, which created a naming collision on the name WallClock.

Instead of naming the host implementation trait something like
`wasi_filesystem::WasiFilesystem`, name it `wasi_filesystem::Host`, and
avoid using the identifier `Host` in other places.

This fixes a collision when generating bindings for the current
wasi-clock API, which contains an interface `wall-clock` which contains
a type `wall-clock`, which created a naming collision on the name
`WallClock`.
@alexcrichton alexcrichton added this pull request to the merge queue Feb 27, 2023
Merged via the queue into bytecodealliance:main with commit c19b742 Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants