Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cranelift: simplify x-x to 0 #6032

Merged
merged 2 commits into from
Mar 17, 2023
Merged

cranelift: simplify x-x to 0 #6032

merged 2 commits into from
Mar 17, 2023

Conversation

Kmeakin
Copy link
Contributor

@Kmeakin Kmeakin commented Mar 16, 2023

No description provided.

fitzgen
fitzgen approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Out of curiosity, is this something you've seen in the wild, or is it just for completeness?

@fitzgen fitzgen enabled auto-merge March 16, 2023 20:09
cfallin
cfallin reviewed Mar 16, 2023
View reviewed changes
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one nit below and then this should be good to merge.

cranelift/codegen/src/opts/algebraic.isle Outdated Show resolved Hide resolved
@cfallin cfallin disabled auto-merge March 16, 2023 20:11
@Kmeakin
Copy link
Contributor Author

Kmeakin commented Mar 16, 2023

Thanks!

Out of curiosity, is this something you've seen in the wild, or is it just for completeness?

Just for completeness

cfallin
cfallin approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@cfallin cfallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cfallin cfallin enabled auto-merge March 16, 2023 20:27
@cfallin cfallin added this pull request to the merge queue Mar 16, 2023
@alexcrichton alexcrichton removed this pull request from the merge queue due to a manual request Mar 16, 2023
@alexcrichton alexcrichton added this pull request to the merge queue Mar 16, 2023
@github-actions github-actions bot added the cranelift Issues related to the Cranelift code generator label Mar 16, 2023
@alexcrichton alexcrichton removed this pull request from the merge queue due to a manual request Mar 17, 2023
@alexcrichton
Copy link
Member

Apologies for the merge queue frobbing here GitHub has been acting up today and I'm not really sure what's going on...

@alexcrichton alexcrichton added this pull request to the merge queue Mar 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Mar 17, 2023
@alexcrichton alexcrichton enabled auto-merge March 17, 2023 14:55
@alexcrichton alexcrichton added this pull request to the merge queue Mar 17, 2023
@alexcrichton alexcrichton merged commit b53d66e into bytecodealliance:main Mar 17, 2023
@jameysharp jameysharp mentioned this pull request Apr 5, 2023
Merged
@Kmeakin Kmeakin deleted the isub-self branch January 30, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

@cfallin cfallin cfallin approved these changes

Assignees
No one assigned
Labels
cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kmeakin @alexcrichton @fitzgen @cfallin