Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cranelift: rewrite x*-1 to ineg(x) #6052

Merged
merged 2 commits into from
Mar 17, 2023
Merged

cranelift: rewrite x*-1 to ineg(x) #6052

merged 2 commits into from
Mar 17, 2023

Conversation

Kmeakin
Copy link
Contributor

@Kmeakin Kmeakin commented Mar 17, 2023 

;; x*-1 == -1*x == ineg(x).

@github-actions github-actions bot added the cranelift Issues related to the Cranelift code generator label Mar 17, 2023
fitzgen
fitzgen reviewed Mar 17, 2023
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with nitpick below addressed.

cranelift/filetests/filetests/egraph/algebraic.clif Show resolved Hide resolved
@Kmeakin Kmeakin requested review from fitzgen and removed request for fitzgen March 17, 2023 19:39
fitzgen
fitzgen approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen fitzgen enabled auto-merge March 17, 2023 19:49
@fitzgen fitzgen added this pull request to the merge queue Mar 17, 2023
@fitzgen fitzgen merged commit 208d09e into bytecodealliance:main Mar 17, 2023
@jameysharp jameysharp mentioned this pull request Apr 5, 2023
Merged
@Kmeakin Kmeakin deleted the rewrite-imul-minus-one branch January 30, 2024 00:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
cranelift Issues related to the Cranelift code generator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kmeakin @fitzgen