Backport "Allow WASI to open directories without O_DIRECTORY" (#6163) #6283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
O_DIRECTORY
flag is a request that open should fail if the named path is not a directory. Opening a path which turns out to be a directory is not supposed to fail if this flag is not specified. However, wasi-common required callers to use it when opening directories.With this PR, we always open the path the same way whether or not the
O_DIRECTORY
flag is specified. However, after opening it, westat
it to check whether it turned out to be a directory, and determine which operations the file descriptor should support accordingly. In addition, we explicitly check whether the precondition defined byO_DIRECTORY
is satisfied.On Windows, when opening a path which might be a directory using
CreateFile
, cap-primitives also removes theFILE_SHARE_DELETE
mode. That means that if we implement WASI'spath_open
such that it always usesCreateFile
on Windows, for both files and directories, then holding an open file handle prevents deletion of that file.