Bump regalloc2 #6398
Merged
Bump regalloc2 #6398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchickey
approved these changes
May 17, 2023
elliottt
commented
May 17, 2023
Comment on lines
+1708
to
+1715
| ; movq %rdx, %r11 | ||
| ; movq %rdi, %r8 | ||
| ; shrq %cl, %r8 | ||
| ; movq %rsi, %r10 | ||
| ; shrq %cl, %r10 | ||
| ; movq %rcx, %r11 | ||
| ; movl $0x40, %ecx | ||
| ; movq %rdx, %rdi | ||
| ; movq %r11, %rdi |
There was a problem hiding this comment.
The additional moves here are expected, as we're now creating overlapping liveranges in regalloc2-0.9.0. Follow-on work will involve removing these, but local profiling of benchmarks like bz2, pulldown-cmark, and spidermonkey was not showing any performance regression.
cfallin
approved these changes
May 17, 2023
github-actions
bot
added
the
cranelift
elliottt
force-pushed
the
trevor/regalloc2-0.9.0
branch
from
6438a7c
to
2caf68a
Compare
elliottt
force-pushed
the
trevor/regalloc2-0.9.0
branch
from
2caf68a
to
974ddb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump the regalloc2 dependency to 0.9.0, to pull in some new perf improvements.