feat(preview1): implement fd_readdir
#6453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvolosatovs
changed the title
fd_readdir
|
cc @pchickey |
rvolosatovs
force-pushed
the
feat/fd_readdir
branch
2 times, most recently
from
0294f48 to
8f761ba
Compare
Subscribe to Label Actioncc @kubkon
This issue or pull request has been labeled: "wasi"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
rvolosatovs
force-pushed
the
feat/fd_readdir
branch
from
8f761ba to
f37599d
Compare
rvolosatovs
force-pushed
the
feat/fd_readdir
branch
2 times, most recently
from
f42b436 to
6e58532
Compare
rvolosatovs
force-pushed
the
feat/fd_readdir
branch
4 times, most recently
from
8f19fcc to
0498e3f
Compare
pchickey
approved these changes
May 25, 2023
| ( | ||
| types::Dirent { | ||
| d_next: 2u64.to_le(), | ||
| d_ino: fd_inode.to_le(), // NOTE: legacy implementation returns `fd` inode here |
There was a problem hiding this comment.
That is unfortunate, I never knew about this bug.
I am not sure what to do with this. We decided to get rid of providing .. in the entries stream in preview 2, because it doesn't really fit the capability model - a preopen doesn't have a ... I don't think we have any way to implement this correctly, so I guess we just have to hope that this bug doesn't cause problems for userland
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
duh Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
prtest:full Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
rvolosatovs
force-pushed
the
feat/fd_readdir
branch
from
0498e3f to
e03645d
Compare
|
Rebased and addressed feedback @pchickey |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #6370 #6454
This includes a few somewhat related fixes in the host adapter, including
fd_closefix bringing the host adapter almost to feature parity with component adapter.@pchickey will handle sockets and polling, at which point this whole work should be done