Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Honor ModuleVersionStrategy in Engine::precompile_compatibility_hash #6457

Merged

Conversation

ianks
Copy link
Contributor

@ianks ianks commented May 25, 2023

When looking into replacing our bespoke implementation of #5826, I noticed it would not make use of a custom versioning strategy. This makes it so we cannot assert compatibility if we determine things work for our use case. This is important because we have to re-serialize a ton of modules when versions change, and don't want to do so unnecessarily.

@ianks ianks requested a review from a team as a code owner May 25, 2023 17:05
@ianks ianks requested review from fitzgen and removed request for a team May 25, 2023 17:05
@ianks ianks force-pushed the module-version-precompatibility-hash branch from 02402c2 to e7a07a1 Compare May 25, 2023 17:08
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen fitzgen enabled auto-merge May 25, 2023 17:15
@fitzgen fitzgen added this pull request to the merge queue May 25, 2023
@github-actions github-actions bot added wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime labels May 25, 2023
@github-actions
Copy link

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:api", "wasmtime:config"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@github-actions
Copy link

Label Messager: wasmtime:config

It looks like you are changing Wasmtime's configuration options. Make sure to
complete this check list:

  • If you added a new Config method, you wrote extensive documentation for
    it.

    Our documentation should be of the following form:

    Short, simple summary sentence.
    
    More details. These details can be multiple paragraphs. There should be
    information about not just the method, but its parameters and results as
    well.
    
    Is this method fallible? If so, when can it return an error?
    
    Can this method panic? If so, when does it panic?
    
    # Example
    
    Optional example here.
    
  • If you added a new Config method, or modified an existing one, you
    ensured that this configuration is exercised by the fuzz targets.

    For example, if you expose a new strategy for allocating the next instance
    slot inside the pooling allocator, you should ensure that at least one of our
    fuzz targets exercises that new strategy.

    Often, all that is required of you is to ensure that there is a knob for this
    configuration option in wasmtime_fuzzing::Config (or one
    of its nested structs).

    Rarely, this may require authoring a new fuzz target to specifically test this
    configuration. See our docs on fuzzing for more details.

  • If you are enabling a configuration option by default, make sure that it
    has been fuzzed for at least two weeks before turning it on by default.


To modify this label's message, edit the .github/label-messager/wasmtime-config.md file.

To add new label messages or remove existing label messages, edit the
.github/label-messager.json configuration file.

Learn more.

@ianks
Copy link
Contributor Author

ianks commented May 25, 2023

Hmm, for some reason clicking the checkboxes does nothing. I imagine someone else needs to do this?

Merged via the queue into bytecodealliance:main with commit 791d6f9 May 25, 2023
@ianks ianks deleted the module-version-precompatibility-hash branch May 25, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:api Related to the API of the `wasmtime` crate itself wasmtime:config Issues related to the configuration of Wasmtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants