Migrate dir to yanix #650
Closed
Migrate dir to yanix #650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
November 28, 2019 17:54
This commit adds `yanix` crate as a Unix dependency for `wasi-common`. `yanix` stands for Yet Another Nix crate and is exactly what the name suggests: a crate in the spirit of the `nix` crate featuring certain adjusments and additions tailored specfically to its main application area which are implementation of WASI syscalls.
Having introduced `yanix` crate as an in-house replacement for the `nix` crate, this commit makes the necessary changes to `wasi-common` to depend _only_ on `yanix` crate.
This commit migrates our internal `libc::DIR` and `libc::dirent` wrappers to the `yanix` crate.
kubkon
force-pushed
the
migrate-dir-to-yanix
branch
from
7d5d9e9 to
69d0af8
Compare
kubkon
force-pushed
the
migrate-dir-to-yanix
branch
from
2260c91 to
afe820d
Compare
kubkon
requested review from
sunfishcode and
peterhuene
and removed request for
sunfishcode
|
cc @marmistrz |
|
Closed in favour of #649 which includes those changes in a slightly different form. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit migrates our internal
libc::DIRandlibc::direntwrappers to theyanixcrate.NB this PR builds on #649.