cranelift: Remove the fcvt_low_from_sint
instruction
#6565
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes this instruction since it's a combination of
swiden_low
plusfcvt_from_sint
. This was used by the WebAssemblyf64x2.convert_low_i32x4_s
instruction previously but the corresponding unsigned variant of the instruction,f64x2.convert_low_i32x4_u
, used auwiden_low
plusfcvt_from_uint
combo. To help simplify Cranelift's instruction set and to make these two instructions mirrors of each other the Cranelift instruction is removed.The s390x and AArch64 backend lowering rules for this instruction could simply be deleted as the previous combination of the
swiden_low
andfcvt_from_sint
lowering rules produces the same code. The x64 backend moved its lowering to a special case of thefcvt_from_sint
lowering.