Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only expose the preview2 module if its feature is enabled #6615

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Only expose the preview2 module if its feature is enabled #6615

merged 1 commit into from
Jun 21, 2023

Conversation

elliottt
Copy link
Member

Allow building wasmtime-wasi with --no-default-features by configuring the top-level preview2 module with its feature.

@elliottt elliottt requested a review from pchickey June 21, 2023 15:56
@elliottt elliottt marked this pull request as ready for review June 21, 2023 15:56
@elliottt elliottt requested a review from a team as a code owner June 21, 2023 15:56
@elliottt elliottt removed the request for review from a team June 21, 2023 15:56
@elliottt elliottt added this pull request to the merge queue Jun 21, 2023
Merged via the queue into bytecodealliance:main with commit 4adae2d Jun 21, 2023
@elliottt elliottt deleted the trevor/preview2-cfg branch June 21, 2023 16:57
@elliottt elliottt mentioned this pull request Jun 21, 2023
Merged
elliottt added a commit to elliottt/wasmtime that referenced this pull request Jun 21, 2023
@elliottt
Only expose the preview2 module if its feature is enabled (bytecodeal…
bed81fd 
…liance#6615)
@elliottt elliottt mentioned this pull request Jun 21, 2023
Merged
elliottt added a commit that referenced this pull request Jun 21, 2023
@elliottt
Only expose the preview2 module if its feature is enabled (#6615) (#6616
15e9d7f 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

@pchickey pchickey Awaiting requested review from pchickey

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elliottt @alexcrichton