[11.0.0] Update some minimum version requirements. #6758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is an attempt to add another CI check for Wasmtime to ensure that the minimum version bounds on all of our dependencies are accurate. This is not a stable feature of Cargo and thus requires usage of nightly. Additionally one of the reasons it's not stable is that the DX is not great as many minimal-versions errors come from transitive dependencies that we can't do anything about. Nevertheless I figure it might be good to try out having it on CI and see how it fares. This is inspired by bytecodealliance#6755 where we picked up a dependency on a newer version of `system-interface` but forgot to update the minimum version bound. Whether or not this prevents the issue or causes too many headaches is I think yet to be seen.
fitzgen
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seeks to fix #6755 by updating the 11.0.0 release branch's minimum version requirements for a few crates. This brings in the CI proposed by #6757 and then gets it passing locally by updating our
clapand oursystem-interfacedependencies. Note thatCargo.lockis not changing here which is intentional because the goal is to have the lower bound of the dependency be what's inCargo.lockwhich is what we're testing against.Also note that the actual modifications to dependency requirements is not needed on
maindue to other PRs that update dependencies. As such the dependency version requirements here are only required for the release branch.