Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand further minimization section of documentation #7350

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

alexcrichton
Copy link
Member

This commit fills out the page about producing minimal builds a bit more. The intention here is to provide examples of ideas about how to reduce size further as well as current limitations and how they can be evaluated.

This commit fills out the page about producing minimal builds a bit
more. The intention here is to provide examples of ideas about how to
reduce size further as well as current limitations and how they can be
evaluated.
@github-actions github-actions bot added the wasmtime:docs Issues related to Wasmtime's documentation label Oct 24, 2023
@alexcrichton alexcrichton marked this pull request as ready for review October 24, 2023 19:19
@alexcrichton alexcrichton requested a review from a team as a code owner October 24, 2023 19:19
@alexcrichton alexcrichton requested review from abrown and removed request for a team October 24, 2023 19:19
Copy link
Contributor

@abrown abrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Couldn't resist some verbiage nits.

Comment on lines 224 to 226
~2.8M dynamic library. This is currently the smallest that can be gained with
the source-code as-is, but there's still possible size reductions which haven't
been implemented yet.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
~2.8M dynamic library. This is currently the smallest that can be gained with
the source-code as-is, but there's still possible size reductions which haven't
been implemented yet.
~2.8M dynamic library. This is currently the smallest size with the source code
as-is, but there are more size reductions which haven't been implemented yet.

from a compiled footprint point of view while not sacrificing everything in
terms of performance. Note though that Winch is still under development.

Above is some future avenues to take in terms of reducing the binary size of
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Above is some future avenues to take in terms of reducing the binary size of
Above are some future avenues to take in terms of reducing the binary size of

@alexcrichton alexcrichton added this pull request to the merge queue Oct 25, 2023
Merged via the queue into bytecodealliance:main with commit 205a5d2 Oct 25, 2023
18 checks passed
@alexcrichton alexcrichton deleted the fill-out-more-docs branch October 25, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wasmtime:docs Issues related to Wasmtime's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants