wasi-sockets: Add SO_REUSEADDR back in #7690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This inadvertently removed in 8ca8056 when switching from `bind_existing_tcp_listener` to `rustix::net::bind`
alexcrichton
approved these changes
Dec 14, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
rylev
reviewed
Dec 15, 2023
|
This should be good to go again. In ran into EADDRINUSE issues on my local machine when binding to a specific (but random) port. So I've modified the tests to give it a few attempts. |
alexcrichton
approved these changes
Dec 17, 2023
dhil
pushed a commit
to dhil/wasmtime
that referenced
this pull request
Dec 29, 2023
* Restore SO_REUSEADDR. This inadvertently removed in 8ca8056 when switching from `bind_existing_tcp_listener` to `rustix::net::bind` * Remove AddressInUse workarounds by generating a random port. * fmt * Ignore unused_variables warning * Prevent spurious test failures by trying again a few times on EADDRINUSE * Fix grammar in .wit documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7662 the call to
bind_existing_tcp_listenerwas replaced withrustix::net::bind. Unfortunately, besides callingbind,bind_existing_tcp_listeneralso setSO_REUSEADDR. This PR restores that behavior. I've added an integration test and a note to the WITs too.Unrelated: I also removed the workarounds in the Bind tests:
by using a random generated port instead of a single constant.