Make wasmtime dependency in wiggle and wasi-common optional with a default feature #7792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to use
wasi-common(and thus alsowiggle) to provide a commonWasiCtximplementation that is reused betweenwasmtimeand a custom runtime (as briefly mentioned in #7776). At the moment, compiling these packages also compileswasmtime, which is not supported on my platform. I propose to add an enabled-by-default feature towasi-commonandwigglethat guards allwasmtime-specific code and allows both packages to be compiled without a dependency onwasmtimeusingdefault-features = false.