Rename generated structures to Guest in bindgen
#7794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors how traits for the host are all called `Host` and it avoids name clashes with types that share the name of the interface they are in. I've also added some simple debugging of macro-generated code to get better error messages. Closes bytecodealliance#7775
pchickey
approved these changes
Jan 18, 2024
alexcrichton
added a commit
to alexcrichton/witx-bindgen
that referenced
this pull request
Jan 31, 2024
Lift the approach I added in bytecodealliance/wasmtime#7794
alexcrichton
added a commit
to alexcrichton/witx-bindgen
that referenced
this pull request
Jan 31, 2024
Lift the approach I added in bytecodealliance/wasmtime#7794
alexcrichton
added a commit
to bytecodealliance/wit-bindgen
that referenced
this pull request
Feb 2, 2024
Lift the approach I added in bytecodealliance/wasmtime#7794
rvolosatovs
pushed a commit
to bytecodealliance/wrpc
that referenced
this pull request
May 23, 2024
Lift the approach I added in bytecodealliance/wasmtime#7794
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors how traits for the host are all called
Hostand it avoids name clashes with types that share the name of the interface they are in.I've also added some simple debugging of macro-generated code to get better error messages.
Closes #7775