Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add C API for GuestProfiler #7854

Merged
merged 7 commits into from
Feb 5, 2024
Merged

Add C API for GuestProfiler #7854

merged 7 commits into from
Feb 5, 2024

Conversation

Milek7
Copy link
Contributor

@Milek7 Milek7 commented Feb 1, 2024

No description provided.

@Milek7 Milek7 requested a review from a team as a code owner February 1, 2024 03:32
@Milek7 Milek7 requested review from alexcrichton and removed request for a team February 1, 2024 03:32
@Milek7
Copy link
Contributor Author

Milek7 commented Feb 1, 2024

Sorry for the noise with #7853, I messed up with Git.

@github-actions github-actions bot added the wasmtime:c-api Issues pertaining to the C API. label Feb 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 1, 2024

Subscribe to Label Action

cc @peterhuene

This issue or pull request has been labeled: "wasmtime:c-api"

Thus the following users have been cc'd because of the following labels:

  • peterhuene: wasmtime:c-api

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

alexcrichton
alexcrichton reviewed Feb 2, 2024
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR here, and looks good to me! I've got some small suggestions here and there but let me know if I can clarify or help out.

crates/c-api/include/wasmtime/profiling.h Show resolved Hide resolved
crates/c-api/include/wasmtime/profiling.h Outdated Show resolved Hide resolved
crates/c-api/src/profiling.rs Outdated Show resolved Hide resolved
@Milek7
Copy link
Contributor Author

Milek7 commented Feb 2, 2024

I think I addressed everything for now.

alexcrichton
alexcrichton approved these changes Feb 5, 2024
View reviewed changes
Copy link
Member

@alexcrichton alexcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

@alexcrichton alexcrichton added this pull request to the merge queue Feb 5, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2024
@alexcrichton alexcrichton added this pull request to the merge queue Feb 5, 2024
Merged via the queue into bytecodealliance:main with commit d4eaacd Feb 5, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton Awaiting requested review from alexcrichton

Assignees
No one assigned
Labels
wasmtime:c-api Issues pertaining to the C API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Milek7 @alexcrichton