Support finishing component types without compilation artifacts #7888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As referenced in this PR, the addition of component type reflection support breaks jco's current dependence on
wasmtime-environ
, and since jco doesn't leverage anEngine
, I'm not immediately aware of a good way to adapt jco. So this PR just does the simple thing and reintroduces the oldfinish
function with the new namefinish_sans_reflection
, right next to the one that was updated for reflection support, though if there's a way I'm missing to adapt jco, then this could be reconsidered.