Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces several optimizations to speed up the compilation of function calls:
ABISig
on every function call.ABISig
on every function call.CallKnown
andCallUnknown
instructions to make theBoxCallInfo
field in the struct optional. Prior to this change, from Winch's perspective each call lowering involved a heap allocation, using the default values forBoxCallInfo
, which in the end are not used by Winch.Stack
to use aSmallVec
rather than aVec
. Many of the operations involving builtin function calls require inserting elements at arbitrary offsets in the stack and using aSmallVec
makes this process more efficient.With the changes mentioned above, I observed ~30% improvement in compilation times for modules that are call-heavy.