Add CLI flags for instance limits #8027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While experimenting with `wasmtime serve`, I found it helpful to be able to configure some of the maximum limits of the various objects stored in the pooling allocator. This change surfaces some new `-O total-*` flags for controlling these limits from the command line.
abrown
commented
Feb 28, 2024
crates/cli-flags/src/lib.rs
Outdated
| pub total_tables: Option<u32>, | ||
|
|
||
| /// The maximum number of WebAssembly stacks which can be created. | ||
| pub total_stacks: Option<u32>, |
There was a problem hiding this comment.
Another option here, since all of these default to the same number currently, is to have a single flag --total-pool-slots or the like that sets all of these together. But maybe someone wants to control these in a bit more fine-grained way, so I went down this route instead.
There was a problem hiding this comment.
Agreed having all the knobs here is fine, the goal is to reflect the options of Config on the CLI and this does that well.
Mind adding pool or pooling at the front of the options though to emphasize that they're only used as configuration to the pooling allocator?
alexcrichton
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While experimenting with
wasmtime serve, I found it helpful to be able to configure some of the maximum limits of the various objects stored in the pooling allocator. This change surfaces some new-O total-*flags for controlling these limits from the command line.