wasmtime-wasi: introduce WasiP1Ctx #8053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
wasi
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "wasi", "wasmtime:c-api"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
lpereira
approved these changes
Mar 6, 2024
… closure and add a few missing bits of functionality for use in the c-api
pchickey
changed the title
pchickey
requested review from
fitzgen and
elliottt
and removed request for
a team and
fitzgen
|
This PR should be backported to the release-19.0.0 branch |
elliottt
pushed a commit
to elliottt/wasmtime
that referenced
this pull request
Mar 8, 2024
… closure (bytecodealliance#8053) and add a few missing bits of functionality for use in the c-api
elliottt
added a commit
that referenced
this pull request
Mar 8, 2024
* wasmtime-wasi: introduce WasiP1Ctx, re-jigger p0 & p1 linkers to take closure (#8053) and add a few missing bits of functionality for use in the c-api * wasmtime c-api: warn that wasi_config_preopen_socket is deprecated in next release (#8064) this PR will be backported to the release-19.0.0 branch prior to the 19 release. * Add release notes --------- Co-authored-by: Pat Hickey <phickey@fastly.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
wasmtime_wasi::WasiP1Ctx, which is aWasiCtxfor just using WASI P1 (and P0).This simplifies user experience for users migrating from wasi-common's P1 support - it means they don't have to know about the
*Viewtraits or theWasiPreview1Adapter, which are just implementation details to a P1 embedder.The p1/p0
add_to_linker_{a?}syncfunctions now take a closure that is the lens for the T in Store, to be consistent with wasi-common and in general whatwasmtime::Linkerusers expect.WasiCtxBuilder now has a convenient function
build_p1(&mut self) -> WasiP1Ctxthat can be used in the place ofbuild(&mut self) -> WasiCtxfor users targeting a P1 embedding.This PR also adds two trivial methods to WasiCtxBuilder to reflect ones that existed in wasi-common;s:
inherit_envandinherit_args.Finally, this PR adds
AsyncStdinStreamandAsyncStdoutStreamas wrappers onAsyncReadStreamandAsyncWriteStreamto provide implementations ofStdinStreamandStdoutStream. (This could be separated into a totally different PR, but it doesnt seem worth the e-paperwork overhead to bother.) These provide parity with the wasi-common affordances for piping stdio to/from files, which happen to be used in the c-api.The top-level tests and examples that were using
wasi-commonare updated to usewasmtime-wasi::WasiP1Ctx.