x64: Refactor lowerings for insertlane
#8167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going through old PRs I stumbled across bytecodealliance#2716 which is quite old at this point. Upon adding the tests to `main` I see that most of it is actually implemented except for load-lane-from-memory where the lane size is 8 or 16 bits. That requires explicitly opting-in with `sinkable_load_exact` so this PR now subsumes the tests of bytecodealliance#2716 in addition to implementing this missing hole in lowerings. This refactoring shuffles around where definitions are located to more easily have access to `Value` to perform the relevant match. The generic `vec_insert_lane` helper is now gone as well in lieu of direct matches on `insertlane` lowerings. Closes bytecodealliance#2716
github-actions
bot
added
cranelift
cfallin
approved these changes
Mar 18, 2024
| (rule (f32x4_insertlane vec val idx) | ||
| (f32x4_insertlane_fallback vec val idx)) | ||
|
|
||
| ;; Helper function used below for `insertlane` but also here for other |
There was a problem hiding this comment.
for other ... (lowerings?) -- missing comment line in code motion
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going through old PRs I stumbled across #2716 which is quite old at this point. Upon adding the tests to
mainI see that most of it is actually implemented except for load-lane-from-memory where the lane size is 8 or 16 bits. That requires explicitly opting-in withsinkable_load_exactso this PR now subsumes the tests of #2716 in addition to implementing this missing hole in lowerings.This refactoring shuffles around where definitions are located to more easily have access to
Valueto perform the relevant match. The genericvec_insert_lanehelper is now gone as well in lieu of direct matches oninsertlanelowerings.Closes #2716