wasmtime-c-api: Add support for GC references to the wasm_* C API functions
#8326
Conversation
fitzgen
force-pushed
the
gc-refs-in-c-api-again
branch
from
69ef9bc
to
5bc5abf
Compare
Subscribe to Label Actioncc @peterhuene
This issue or pull request has been labeled: "wasmtime:c-api"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
There was a problem hiding this comment.
Personally I'm feeling pretty uneasy about this having a self-referencing store. This is exclusively for the wasm_* API which none of our wasmtime-* bindings are using as well. Given that my gut would actually be the opposite of what you're thinking which is to basically stop supporting reference types in the wasm_* APIs and only support them in wasmtime_* APIs. The wasm.h header feels "too incompatible" with our implementation, to the extent that I'm pretty worried about the self-references and unsafe and bugs here. Given the fact that we'll have a full implementation available with wasmtime_* I'd be tempted to tailor those to what we need and only have that for now.
| pub type CStoreContext<'a> = StoreContext<'a, StoreData>; | ||
| pub type CStoreContextMut<'a> = StoreContextMut<'a, StoreData>; | ||
| pub type WasmtimeStoreContext<'a> = StoreContext<'a, WasmtimeStoreData>; | ||
| pub type WasmtimeStoreContextMut<'a> = StoreContextMut<'a, WasmtimeStoreData>; | ||
|
|
There was a problem hiding this comment.
Could these renamings perhaps be split out either commit-wise or PR-wise? It's a bit difficult to disentangle what's going on here with simultaneous renamings.
There was a problem hiding this comment.
Split out the renaming to #8344
Yeah, that's fair. I have a branch with |
Does not add support for the
wasmtime_*functions yet.