Commits on Apr 13, 2024

1. fuzzgen: Use the correct ISA when running NaN Canonicalization pass …

   cranelift-fuzzgen unconditionally runs the NaN Canonicalization pass on all functions that it generates. This is so that we can ensure that when running in the interpreter vs natively we get the same bitpattern for all NaN's.
   
   Until now we just picked a random ISA (the host ISA), disabled the verifier and ran the pass with that. This was because the ISA didn't really matter for the passes that we wanted to run.
   
   In bytecodealliance#8313 the ISA now drives some codgen decisions for the NaN Canonicalization pass. Namely, if the ISA supports Vectors, it tries to use that.
   
   In bytecodealliance#8359 there was a fuzz bug reported where fuzzgen generated vector code for RISC-V without the `has_v` flag, something that should *never* happen, because we simply cannot compile that code.
   
   It turns out that fuzzgen did not generate vector code itself. But since we were passing the host ISA to the nan canonicalization pass, it assumed that it could use vectors and did so. But the actual target isa did not support vectors.
   
   To fix this, we now correctly pass the target isa that we are building a function for.

   

   afonso360 committed Apr 13, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for 590afd4
   • Browse repository at this point

   Copy the full SHA

   590afd4 View commit details

   Browse the repository at this point in the history