Fix tail calls being turned on by default #8682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logic in `Config` to conditionally enable tail calls wasn't handling the case where the configured compiler strategy was `Strategy::Auto` meaning that by default tail calls weren't actually enabled. This commit refactors handling of `Strategy` to avoid storing `Strategy::Auto` in `CompilerConfig` so tests against it can use either cranelift or winch.
fitzgen
approved these changes
May 22, 2024
CryZe
added a commit
to CryZe/website
that referenced
this pull request
Jun 9, 2024
Apparently the situation is a little bit complicated. The feature is enabled since [21](https://github.com/bytecodealliance/wasmtime/blob/release-21.0.0/RELEASES.md#added), but only for the Cranelift backend, except for the s390x architecture. However, the feature was accidentally not active until [22](bytecodealliance/wasmtime#8682). Also wasmtime 22 isn't out yet (should come out June 17th).
dschuff
pushed a commit
to WebAssembly/website
that referenced
this pull request
Jun 10, 2024
Apparently the situation is a little bit complicated. The feature is enabled since [Version 21](https://github.com/bytecodealliance/wasmtime/blob/release-21.0.0/RELEASES.md#added), but only for the Cranelift backend, except for the s390x architecture. However, the feature was accidentally not active until [Version 22](bytecodealliance/wasmtime#8682). Also wasmtime 22 isn't out yet (should come out June 17th).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logic in
Configto conditionally enable tail calls wasn't handling the case where the configured compiler strategy wasStrategy::Automeaning that by default tail calls weren't actually enabled. This commit refactors handling ofStrategyto avoid storingStrategy::AutoinCompilerConfigso tests against it can use either cranelift or winch.