Pulley: Add memory access instructions with 64-bit offsets #9085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fitzgen
force-pushed
the
pulley-memory-access-big-offset
branch
from
59958c6
to
06fdfb1
Compare
Subscribe to Label Actioncc @fitzgen
This issue or pull request has been labeled: "pulley"
Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
alexcrichton
approved these changes
Aug 9, 2024
pulley/src/interp.rs
Outdated
Comment on lines
954
to
895
| fn load32_u_offset64(&mut self, dst: XReg, ptr: XReg, offset: i64) -> Self::Return { | ||
| let val = unsafe { | ||
| self.state | ||
| .x(ptr) | ||
| .get_ptr::<u32>() | ||
| .byte_offset(offset as isize) | ||
| .read_unaligned() | ||
| }; | ||
| self.state.x_mut(dst).set_u64(u64::from(val)); | ||
| Continuation::Continue | ||
| } |
There was a problem hiding this comment.
Would it perhaps make sense to add a generlized helper load32_u_offset which takes offset: usize which no-offset/offset8/offset64 all call? (and would presumably get inlined and not actually matter at runtime)
There was a problem hiding this comment.
Mayyybe. Right now some of the offset-to-isize conversions are .into() and some are as isize which is a small hiccup, but probably inconsequential. All said, I think I'd prefer to just leave it as-is for now and see what the future brings.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
I had trimmed these instructions from the original upstreaming of the Pulley interpreter because I had mistakenly believed that they were unused. Turns out they are needed for Cranelift's Pulley backend to allow for lowering certain address modes to a single instruction. The alternative, lowering the address modes to a sequence of instructions, would be a bit annoying and these instructions seem generally useful.
fitzgen
force-pushed
the
pulley-memory-access-big-offset
branch
from
06fdfb1
to
ef3fab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had trimmed these instructions from the original upstreaming of the Pulley interpreter because I had mistakenly believed that they were unused. Turns out they are needed for Cranelift's Pulley backend to allow for lowering certain address modes to a single instruction. The alternative, lowering the address modes to a sequence of instructions, would be a bit annoying and these instructions seem generally useful.