Generate async drop methods for resources. #9091
Conversation
In the component model, `resource.drop` is a canonical built-in without a proper name. So I invented a custom naming scheme for the component bindgen config. I went with:
`"[drop]{resource-name}"` where `{resource-name}` is the name as defined in WIT. e.g. `"[drop]input-stream"`.
This shouldn't conflict with anything existing in the wild as WIT identifiers are not allowed to contain square brackets.
github-actions
bot
added
the
wasmtime:api
|
If you're looking for something to test this feature in isolation I'd be glad to add a test for it, but could you point me towards where the component model tests live currently? I tried looking for them in the usual places but couldn't find them. If all you're after is that this is tested somehow and don't care about the test being in isolation or not, I've got a follow-up PR planned for #9058 that will be using this feature. So it will be tested indirectly through that. |
|
Yes I think that this would be good to have a dedicated test for just this. Component-model API tests live at https://github.com/bytecodealliance/wasmtime/tree/main/tests/all/component_model and https://github.com/bytecodealliance/wasmtime/blob/main/tests/all/component_model/async.rs has some examples of doing async things |
|
Check! |
Add the ability to generate async drop methods for resources.
In the component model,
resource.dropis a canonical built-in without a proper name. So I invented a custom naming scheme for the component bindgen config. I went with:"[drop]{resource-name}"where{resource-name}is the name as defined in WIT. e.g."[drop]input-stream".This shouldn't conflict with anything existing in the wild as WIT identifiers are not allowed to contain square brackets.
To the reviewer: please double check
resource_async. I'm not familiar with this part of the codebase.Spawned off from #9058. This change is a prerequisite for a potential solution of that issue, but seems useful enough on its own.