Fuzz the multi-value support #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit enables multi-value by default for the fuzzers, in theory allowing us to find panics and such in the multi-value implementation. Or even runtime errors through the differential fuzzing!
fitzgen
approved these changes
Feb 6, 2020
crates/fuzzing/src/generators.rs
Outdated
| @@ -52,6 +52,7 @@ impl Arbitrary for WasmOptTtf { | |||
| pub struct DifferentialConfig { | |||
| strategy: DifferentialStrategy, | |||
| opt_level: DifferentialOptLevel, | |||
| multi_value: bool, | |||
There was a problem hiding this comment.
I don't think it makes sense to do differential testing between a config with and without multi-value enabled. At best, one side will instantiate and run the wasm OK and the other won't (if the wasm uses multi-value) or they will both instantiate and run the wasm OK (if the wasm doesn't use multi-value). We're not really testing and comparing different compiler pipelines (eg with vs without optimizations) in this scenario, which is what differential testing is supposed to exercise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables multi-value by default for the fuzzers, in theory
allowing us to find panics and such in the multi-value implementation.
Or even runtime errors through the differential fuzzing!
@fitzgen do you think that the implementation is ready for fuzzing? Or should we hold off and fix more bugs before we throw fuzzers at it?