Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Upgrade regalloc2 to 0.9.4" #9193

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

elliottt
Copy link
Member

Reverts #9191

We need to yank regalloc-0.9.4 and bump it to 0.10.0, as a function was removed in 0.9.4.

@elliottt elliottt requested review from a team as code owners August 30, 2024 23:20
@alexcrichton
Copy link
Member

Oh I think this is fine to leave in wasmtime, yanks don't delete the crate it just prevents new dependencies being formed on the crate. In that sense if you yank regalloc2 now then wasmtime will keep building. In that sense this shouldn't be necessary

@elliottt
Copy link
Member Author

Ah, I misunderstood what the effect of yanking the crate was. I'll close the revert 👍

@elliottt elliottt closed this Aug 30, 2024
@bjorn3
Copy link
Contributor

bjorn3 commented Aug 31, 2024

If anyone tries to depend on the wasmtime version on the main branch as library, they can't if they didn't have a lockfile from before 0.9.4 got yanked and there is no regalloc2 version semver compatible with the 0.9.4 dependency requirement. If a non-yanked 0.9.5 existed, this one would be picked, but alas it doesn't exist and thus cargo will return an error.

@alexcrichton
Copy link
Member

Ah that's a good point, if that's causing issues for you I can approve/merge a revert too

@elliottt
Copy link
Member Author

Should we upload a 0.9.5 that's just a re-release of 0.9.3?

@elliottt elliottt reopened this Aug 31, 2024
@elliottt
Copy link
Member Author

Let's just revert the update and restore the changes when we release regalloc2 0.10.0 with safepoint support removed next week.

@alexcrichton alexcrichton added this pull request to the merge queue Aug 31, 2024
Merged via the queue into main with commit 7081b8f Aug 31, 2024
68 checks passed
@alexcrichton alexcrichton deleted the revert-9191-trevor/upgrade-regalloc branch August 31, 2024 16:09
elliottt added a commit to elliottt/wasmtime that referenced this pull request Sep 3, 2024
github-merge-queue bot pushed a commit that referenced this pull request Sep 3, 2024
* Reapply "Upgrade regalloc2 to 0.9.4 (#9191)" (#9193)

This reverts commit 7081b8f.

* Upgrade to regalloc-0.10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants