-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Upgrade regalloc2 to 0.9.4" #9193
Conversation
This reverts commit 098430f.
Oh I think this is fine to leave in wasmtime, yanks don't delete the crate it just prevents new dependencies being formed on the crate. In that sense if you yank regalloc2 now then wasmtime will keep building. In that sense this shouldn't be necessary |
Ah, I misunderstood what the effect of yanking the crate was. I'll close the revert 👍 |
If anyone tries to depend on the wasmtime version on the main branch as library, they can't if they didn't have a lockfile from before 0.9.4 got yanked and there is no regalloc2 version semver compatible with the 0.9.4 dependency requirement. If a non-yanked 0.9.5 existed, this one would be picked, but alas it doesn't exist and thus cargo will return an error. |
Ah that's a good point, if that's causing issues for you I can approve/merge a revert too |
Should we upload a 0.9.5 that's just a re-release of 0.9.3? |
Let's just revert the update and restore the changes when we release regalloc2 0.10.0 with safepoint support removed next week. |
…ealliance#9193) This reverts commit 7081b8f.
Reverts #9191
We need to yank regalloc-0.9.4 and bump it to 0.10.0, as a function was removed in 0.9.4.