Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get wasmtime building on Windows. #92

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Get wasmtime building on Windows. #92

merged 2 commits into from
Apr 3, 2019

Conversation

hrydgard
Copy link
Contributor

@hrydgard hrydgard commented Apr 2, 2019

Requires LLVM binaries from http://releases.llvm.org/download.html at build time (bindgen).

Requires LLVM binaries from http://releases.llvm.org/download.html at
build time (bindgen).
@sunfishcode
Copy link
Member

Cool, thanks for working on this! Would you be able to format the changes with rustfmt?

@hrydgard
Copy link
Contributor Author

hrydgard commented Apr 3, 2019

Sure, just ran cargo fmt. Sorry for missing that! I can squish the commits if you like.

@sunfishcode
Copy link
Member

Looks good, thanks!

@sunfishcode sunfishcode merged commit f5ebdb8 into bytecodealliance:master Apr 3, 2019
@hrydgard hrydgard deleted the windows-buildfixes branch April 3, 2019 13:51
howjmay pushed a commit to howjmay/wasmtime that referenced this pull request Jan 24, 2022
This complements bytecodealliance#3086

Fixes bytecodealliance#63.

Signed-off-by: Stephan Renatus <stephan.renatus@gmail.com>
pchickey pushed a commit to pchickey/wasmtime that referenced this pull request May 12, 2023
…ce#93)

The order of operations for handling the seconds/nanoseconds part of the
structure were a bit off which meant that a nonzero nanosecond field
would have an unexpected effect on the result.

Closes bytecodealliance#92
pchickey pushed a commit to pchickey/wasmtime that referenced this pull request May 16, 2023
…ce#93)

The order of operations for handling the seconds/nanoseconds part of the
structure were a bit off which meant that a nonzero nanosecond field
would have an unexpected effect on the result.

Closes bytecodealliance#92
mooori pushed a commit to mooori/wasmtime that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants