Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use NonNull<u8> for pc instead of *mut u8 #9274

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Use NonNull<u8> for pc instead of *mut u8 #9274

merged 1 commit into from
Sep 19, 2024

Conversation

Kmeakin
Copy link
Contributor

@Kmeakin Kmeakin commented Sep 18, 2024

Split off from #9251

@Kmeakin Kmeakin requested a review from a team as a code owner September 18, 2024 00:17
@Kmeakin Kmeakin requested review from alexcrichton and removed request for a team September 18, 2024 00:17
@alexcrichton alexcrichton added this pull request to the merge queue Sep 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 18, 2024
@Kmeakin
Copy link
Contributor Author

Kmeakin commented Sep 18, 2024 •
edited
Loading

The methods on NonNull were stabilized in 1.80, so we'll have to wait until 1.82 is released on 17 October and use pollyfills in the meantime

@Kmeakin
Use NonNull<u8> for pc instead of *mut u8
ff65dfd 
Copyright (c) 2024, Arm Limited.

Signed-off-by: Karl Meakin <karl.meakin@arm.com>
@github-actions github-actions bot added the pulley Issues related to the Pulley interpreter label Sep 18, 2024
@github-actions GitHub Actions
Copy link

Subscribe to Label Action

cc @fitzgen

This issue or pull request has been labeled: "pulley"

Thus the following users have been cc'd because of the following labels:

  • fitzgen: pulley

To subscribe or unsubscribe from this label, edit the .github/subscribe-to-label.json configuration file.

Learn more.

@alexcrichton
Copy link
Member

We're unfortunately held back on Rust versions by OSS-Fuzz right now (see #9231 for a bit more info), so it might be best to go ahead and get this working on our current 1.78 MSRV. I think it may just require a few more accessor methods in a few places? (e.g. .as_ptr().read() instead of .read())

@Kmeakin
Copy link
Contributor Author

Kmeakin commented Sep 19, 2024

We're unfortunately held back on Rust versions by OSS-Fuzz right now (see #9231 for a bit more info), so it might be best to go ahead and get this working on our current 1.78 MSRV. I think it may just require a few more accessor methods in a few places? (e.g. .as_ptr().read() instead of .read())

Should pass on 1.78 rust with the newest patch

@alexcrichton
Copy link
Member

Oh oops sorry I think I missed the update

@alexcrichton alexcrichton added this pull request to the merge queue Sep 19, 2024
@fitzgen fitzgen mentioned this pull request Sep 19, 2024
Merged
Merged via the queue into bytecodealliance:main with commit b0ffce1 Sep 19, 2024
35 checks passed
@Kmeakin Kmeakin deleted the km/pulley/nonnull branch October 29, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcrichton alexcrichton alexcrichton approved these changes

Assignees
No one assigned
Labels
pulley Issues related to the Pulley interpreter
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kmeakin @alexcrichton