Implement the wide-arithmetic proposal #9403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements the [wide-arithmetic] proposal in Wasmtime. This is a pretty easy proposal to implement due to Cranelift already having support for all the various instructions. The features implemented here are: * Cranelift support for the four new instructions. * A new `Config::wasm_wide_arithmetic` option. * A new `-Wwide-arithmetic` CLI flag. * A new `wasmtime_config_wasm_wide_arithmetic_set` C API function. * Support for fuzzing this proposal * Generation is implemented in `wasm-smith` . * While it's off-by-default in `wasm-smith` it's enabled-by-default here. * Differential execution is only possible against Wasmtime right now. * Single-instruction module support was added for these new instructions. * Tests for some simple cases plus randomly-generated tests. * Example disassemblies for new instructions on Cranelift architectures. [wide-arithmetic]: https://github.com/WebAssembly/wide-arithmetic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements the wide-arithmetic proposal in Wasmtime. This is a pretty easy proposal to implement due to Cranelift already having support for all the various instructions. The features implemented here are:
Config::wasm_wide_arithmeticoption.-Wwide-arithmeticCLI flag.wasmtime_config_wasm_wide_arithmetic_setC API function.wasm-smith.wasm-smithit's enabled-by-default here.