Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing pooling allocator options as CLI flags (#9256) #9447

Merged
merged 6 commits into from
Oct 10, 2024
Merged

Add missing pooling allocator options as CLI flags (#9256) #9447

merged 6 commits into from
Oct 10, 2024
+99 −6

Conversation

omarjatoi
Copy link
Contributor

@omarjatoi omarjatoi commented Oct 10, 2024 •
edited
Loading

From #9256, this PR adds the missing pooling allocator configuration options as CLI flags. I also renamed some minor things for consistency.

@omarjatoi omarjatoi requested a review from a team as a code owner October 10, 2024 17:28
@omarjatoi omarjatoi requested review from fitzgen and removed request for a team October 10, 2024 17:28
fitzgen
fitzgen reviewed Oct 10, 2024
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a couple comments below

crates/cli-flags/src/lib.rs Outdated Show resolved Hide resolved
crates/cli-flags/src/lib.rs Outdated Show resolved Hide resolved
crates/cli-flags/src/lib.rs Show resolved Hide resolved
@omarjatoi
Copy link
Contributor Author

Thanks for the comments! I've added defaults in comments and cleaned up the commits.

fitzgen
fitzgen approved these changes Oct 10, 2024
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fitzgen fitzgen added this pull request to the merge queue Oct 10, 2024
Merged via the queue into bytecodealliance:main with commit f59cad1 Oct 10, 2024
39 checks passed
@omarjatoi omarjatoi deleted the 9256-pooling-allocator-flags branch October 10, 2024 19:51
@alexcrichton alexcrichton mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omarjatoi @fitzgen